From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 27 Aug 2026 10:54:51 GMT
Subject: Re: [PATCH 08/10] builtin/fsck: move bitmap verification into the packed source
Message-ID: <CAOLa=ZQwhpPMrgeLW8W0pezH8VFrqDiiAfet3G_jDRQDu_KQUg@mail.gmail.com>
In-Reply-To: <20260825-pks-odb-source-fsck-v1-8-b756de0bf24f@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> The checks for bitmaps live in `verify_bitmap_files()`, which is called
> by "builtin/fsck.c". These checks are obviously specific to the "packed"
> backend.
>
> Move the logic into `odb_source_packed_fsck()`. As in preceding commits,
> this means that we now properly honor both "--connectivity-only" and
> "--no-full". Furthermore, we drop the dedicated `ERROR_BITMAP` bit and
> instead use the generic `ERROR_OBJECT` bit.
>
> Note that this change also adapts `verify_bitmap_files()` to be
> focussed on a single "packed" source instead of verifying bitmaps from

nit: s/focussed/focused

> all sources. This change is required as we already know to loop around
> the sources in `odb_fsck()` itself.
>

[snip]

changes look good