From: Karthik Nayak Date: Sun, 26 Jul 2015 04:36:15 GMT Subject: Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left Message-ID: In-Reply-To: On Sun, Jul 26, 2015 at 9:38 AM, Eric Sunshine wrote: > On Fri, Jul 24, 2015 at 3:04 PM, Karthik Nayak wrote: >> Add a new atom "align" and support %(align:X) where X is a number. >> This will align the preceeding atom value to the left followed by > > Do you mean "succeeding" or "following" or "next" (or something) > rather than "preceding"? I meant succeeding, I had just changed that, thanks for telling > >> spaces for a total length of X characters. If X is less than the item >> size, the entire atom value is printed. > > Isn't this a pad-right operation? If so, should this be called > %(padright:X) or %(pad:right:X)? > I guess "padright" makes more sense, thanks. >> Signed-off-by: Karthik Nayak > > Also, it is helpful to reviewers if you include an interdiff at the > bottom of your cover letter showing the changes from one version to > another. You can generate an interdiff with "git diff branchname-v4 > branchname-v5", for instance. I've been working on the same branch, and that's why I didn't really provide interdiff's, and I kinda worked on the same branch again, so I wont be giving an interdiff for the next series either, but I'll keep this in mind and follow it from the forthcoming patch series. Thanks -- Regards, Karthik Nayak