From: karthik nayak Date: Mon, 12 Aug 2024 08:27:32 GMT Subject: Re: [PATCH v2 01/22] remote: plug memory leak when aliasing URLs Message-ID: In-Reply-To: <2afa51f9ffedfa6dab51c9515f695ddfe0a9a4f9.1723121979.git.ps@pks.im> Patrick Steinhardt writes: > When we have a `url.*.insteadOf` configuration, then we end up aliasing > URLs when populating remotes. One place where this happens is in > `alias_all_urls()`, where we loop through all remotes and then alias > each of their URLs. The actual aliasing logic is then contained in > `alias_url()`, which returns an allocated string that contains the new > URL. This URL replaces the old URL that we have in the strvec that > contanis all remote URLs. > s/contanis/contains [snip]