From: Karthik Nayak Date: Fri, 05 Jun 2026 14:25:31 GMT Subject: Re: [PATCH 01/16] packfile: rename `struct packfile_store` to `odb_source_packed` Message-ID: In-Reply-To: <20260604-pks-odb-source-packed-v1-1-2e7ab31b4b5c@pks.im> Patrick Steinhardt writes: > Not too long ago, we have introduced the packfile store in b7983adb51 > (packfile: introduce a new `struct packfile_store`, 2025-09-23). This > struct is responsible for managing all of our access to packfiles and is > used as one of the two sources of objects for the "files" source. > > Back when I introduced this structure I didn't have the clear vision yet > that it will eventually also turn into a proper object database source, > and how exactly that infrastructure will look like. Now though it's > becoming increasingly clear that it does make sense to treat it just the > same as any of our other ODB sources. > > The consequence is that the naming is now a bit out-of-date: it's just > another source and will be turned into a proper `struct odb_source` over > the next couple of commits, but it's not named accordingly. > > Rename the structure to `odb_source_packed` to align it with this goal > and to bring it in line with the other sources we already have. > Looks good, I'm assuming we'll also rename drop some of the `packfile_store_*` functions as things get cleaned up in the following commits.