From: Karthik Nayak <karthik.188@gmail.com>
Date: Mon, 20 Jan 2025 10:07:23 GMT
Subject: Re: [PATCH 00/10] reftable: fix -Wsign-compare warnings
Message-ID: <CAOLa=ZQXF8ewDVmusbXPSCPPp9qqj2JRTvZeiiDZRckG5BpV6g@mail.gmail.com>
In-Reply-To: <20250116-b4-pks-reftable-sign-compare-v1-0-bd30e2ee96e7@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Hi,
>
> during the last steps of converting the reftable codebase to become a
> standalone library I noticed that the new -Wsign-compare warnings
> created a bit of a problem due to the `DISABLE_SIGN_COMPARE_WARNINGS`
> macro that we started using. As a consequence I wasn't able to easily
> drop "git-compat-util.h" anymore. This patch series is thus addresses
> the issue by fixing all sign comparison warnings in the reftable
> library.
>
> Thanks!
>

Most of the patches were straightforward and look good. I left only nits
on one commit, which doesn't warrant a re-roll.

Thanks

[snip]