From: Karthik Nayak Date: Mon, 05 Jan 2026 10:55:07 GMT Subject: Re: [PATCH v3] t1300: use test helpers instead of test builtins Message-ID: In-Reply-To: Pushkar Singh writes: > Hi Abraham, > > Thanks for pointing that out. > > Understood. I should keep the commit message itself focused on the change, > and describe what was updated between versions under the `---` section. > > I will send a v4 with the commit message adjusted accordingly and include a > "Changes in v4" note below the separator. > > Thanks for the clarification. > Pushkar > I also find using b4 [1] to be very beneficial to handle this. Where b4 provides patch versioning and you can simply worry about your commits :) [1]: https://b4.docs.kernel.org/en/latest/ > On Sun, Jan 4, 2026 at 9:04 PM Abraham Samuel Adekunle > wrote: >> >> >This version updates the commit message to avoid calling `test` a shell >> >primitive, as suggested. >> >> >Signed-off-by: Pushkar Singh >> >--- >> >> Hello Pushkar, >> >> I think the right approach to send an updated version after modifying your commit >> message is to modify your commit message to INCLUDE the recommendation, not change >> the commit message to the recommendation alone. >> Then under these three dashes after the 'Signed-off-by:', (---), which is here, >> where I am currently replying to you, you state what you changed in the new version >> compared to the previous version. >> >> e.g >> >> Changes in v3: >> - Modified commit message to ... >> - Modified subject to use builtin instead of primitive >> >> >> Thanks >> Abraham.