From: Karthik Nayak <karthik.188@gmail.com>
Date: Wed, 17 Apr 2024 17:23:00 GMT
Subject: Re: [PATCH 1/5] t/helper: stop using `the_index`
Message-ID: <CAOLa=ZQMcxHqXwEZGTAaa4Em6wx_Bx5OWR4qqy79woh2n-bwHw@mail.gmail.com>
In-Reply-To: <7b5ec04efc89af6874461d967bf5f61939e054dd.1713180749.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Convert test-helper tools to use `the_repository->index` instead of
> `the_index`.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  t/helper/test-cache-tree.c           | 17 ++++++------
>  t/helper/test-dump-cache-tree.c      |  5 ++--
>  t/helper/test-dump-split-index.c     | 11 ++++----
>  t/helper/test-dump-untracked-cache.c |  3 +--
>  t/helper/test-lazy-init-name-hash.c  | 39 ++++++++++++++--------------
>  t/helper/test-read-cache.c           |  9 +++----
>  t/helper/test-scrap-cache-tree.c     |  7 +++--
>  t/helper/test-write-cache.c          |  3 +--
>  8 files changed, 43 insertions(+), 51 deletions(-)
>
> diff --git a/t/helper/test-cache-tree.c b/t/helper/test-cache-tree.c
> index e7236392c8..dc89ecfd71 100644
> --- a/t/helper/test-cache-tree.c
> +++ b/t/helper/test-cache-tree.c
> @@ -1,4 +1,3 @@
> -#define USE_THE_INDEX_VARIABLE
>

Nit: It would've been nice to mention what this macro is used for.
Perhaps maybe in the cover letter since its removed from all the commits.