From: Karthik Nayak Date: Wed, 12 Jun 2024 09:33:43 GMT Subject: Re: [PATCH 13/29] merge-recursive: fix memory leak when finalizing merge Message-ID: In-Reply-To: <4ba1343d-1467-46a0-85b0-b249e1ddedf7@gmail.com> Phillip Wood writes: > On 06/06/2024 11:50, Karthik Nayak wrote: >> Patrick Steinhardt writes: >> >>> We do not free some members of `struct merge_options`' private data. >> >> Nit: s/`struct merge_options`'/`struct merge_options`'s/ > > Either is correct, it is a matter of style whether one adds the trailing > "s". > > Best Wishes > > Phillip TIL, thanks Phillip.