From: Karthik Nayak Date: Mon, 08 Jun 2026 15:09:06 GMT Subject: Re: [PATCH 02/16] packfile: move packed source into "odb/" subsystem Message-ID: In-Reply-To: <20260604-pks-odb-source-packed-v1-2-2e7ab31b4b5c@pks.im> Patrick Steinhardt writes: > In subsequent patches we'll be turning `struct odb_source_packed` into a > proper `struct odb_source`. As a first step towards this goal, move its > struct out of "packfile.{c,h}" and into "odb/source-packed.{c,h}". > > This detaches the implementation of the packfile object source from the > generic packfile code, following the same convention already used by the > "files" and "in-memory" sources. > [snip] > diff --git a/odb/source-packed.h b/odb/source-packed.h > new file mode 100644 > index 0000000000..c17068a4f1 > --- /dev/null > +++ b/odb/source-packed.h > @@ -0,0 +1,80 @@ > +#ifndef ODB_SOURCE_PACKED_H > +#define ODB_SOURCE_PACKED_H > + > +#include "odb/source.h" > +#include "strmap.h" > + > +struct packfile_list { > + struct packfile_list_entry *head, *tail; > +}; > + > +struct packfile_list_entry { > + struct packfile_list_entry *next; > + struct packed_git *pack; > +}; > + So this is exposed, because outside of the odb, we also use packfiles in the transport layer. That makes me wonder if these two structures are better kept alonsigde `struct packed_git` in 'packfile.h'. [snip] The rest of the patch looks good.