From: Karthik Nayak <karthik.188@gmail.com>
Date: Sat, 03 Oct 2015 07:14:39 GMT
Subject: Re: [PATCH 2/9] ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>)
Message-ID: <CAOLa=ZQ3tJQ6VD6RBBOU_41=75WB1vrD6ASk5HecnnJse0cJ+Q@mail.gmail.com>
In-Reply-To: <xmqqlhbl3sb6.fsf@gitster.mtv.corp.google.com>

On Sat, Oct 3, 2015 at 2:24 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Implement %(if:equals=<string>) wherein the if condition is only
>> satisfied if the value obtained between the %(if:...) and %(then) atom
>> is the same as the given '<string>'.
>>
>> Similarly, implement (if:notequals=<string>) wherein the if condition
>> is only satisfied if the value obtained between the %(if:...) and
>> %(then) atom is differnt from the given '<string>'.
>>
>> Add tests and Documentation for the same.
>>
>> Mentored-by: Christian Couder <christian.couder@gmail.com>
>> Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
>> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
>> ---
>
> The fast that the patch touches only the narrow parts that are
> specific to %(if),%(then) and %(else) and does not have to touch any
> generic part (other than the populate_value() parser for obvious
> reasons) is a good signal that tells us that the basic structure of
> the code is very sound.  I very much like the direction in which
> this series is going ;-)
>

Thats nice to hear :)

-- 
Regards,
Karthik Nayak