From: Karthik Nayak <karthik.188@gmail.com>
Date: Tue, 02 Dec 2025 22:26:01 GMT
Subject: Re: [PATCH v8 2/3] fetch: fix non-conflicting tags not being committed
Message-ID: <CAOLa=ZQ-O7V9qHbgeuQ78R1bHGDmGEM6fP5Kr9aC0AfvSF8MZA@mail.gmail.com>
In-Reply-To: <aS2Q4-U5kgJ2nNVv@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> On Fri, Nov 21, 2025 at 12:13:46PM +0100, Karthik Nayak wrote:
>> diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
>> index b7059cccaa..4b113d7c27 100755
>> --- a/t/t5510-fetch.sh
>> +++ b/t/t5510-fetch.sh
>> @@ -1577,6 +1578,67 @@ test_expect_success REFFILES 'D/F conflict on case sensitive filesystem with loc
> [snip]
>> +test_expect_success "backfill tags when providing a refspec" '
>> +	test_when_finished rm -rf source target &&
>> +
>> +	git init source &&
>> +	git -C source commit --allow-empty --message common &&
>> +	git clone file://"$(pwd)"/source target &&
>> +	(
>> +	    cd source &&
>> +	    test_commit history &&
>> +	    test_commit fetch-me
>> +	) &&
>> +
>> +	# The "history" tag is backfilled eventhough we requested
>
> Tiny nit, not worth a reroll: s/eventhough/even though/. Other than that
> this patch looks good to me.
>
> Patrick

Will add it in. Thanks!