From: ZheNing Hu <adlternative@gmail.com>
Date: Sun, 21 Mar 2021 14:04:54 GMT
Subject: Re: [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value
Message-ID: <CAOLTT8Tnt_Ai9xyXSYQ9dt4Vh1iViiihiMNEY0fzSGk=Xgw6cA@mail.gmail.com>
In-Reply-To: <1722fbad-6ff3-444f-ad3f-59e37b640fc7@gmail.com>

> I think please consider this case: When I add --trailer "Reviewed-by:@bat", and there are two
> identity pairs that match (`batman <email1>` and `batman <email2>`), I need to choose one that
> will be in the trailer (for example because <email1> is primary email). So a disambiguation
> prompt should be added, something like:
>
> ```
> There are <N> identities that match, please choose one that will be added to the trailer:
> 1) batman <email1>
> 2) batman <email2>
> ...
> n) batman <emailn>
> ```
>
Hi,

I think this kind of prompt will be beneficial to users, temporarily
adopt the method of
`find_author_by_nickname()` to get the last match commit "name <eamil>" pair.
If I want to find all these matched "name <eamil>" pairs and exclude
duplicates, I may need to
think about it for a while.

> The prompt can be repeated for each trailer values that are non-unique.
>
> Thanks
>
> --
> An old man doll... just what I always wanted! - Clara

Thanks.
--
ZheNing Hu