From: ZheNing Hu <adlternative@gmail.com>
Date: Mon, 22 Mar 2021 00:39:08 GMT
Subject: Re: [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value
Message-ID: <CAOLTT8TU+XwLmDQRROHW6iumFgMKok9mi+_OBmN4FbvgWkNb7Q@mail.gmail.com>
In-Reply-To: <xmqqwnu0bga9.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> 于2021年3月22日周一 上午12:52写道：
>
> Christian Couder <christian.couder@gmail.com> writes:
>
> >> "Signed-off-by:C O <Mister@email.com>" is often too
> >> verbose and error-prone.
> >
> > The 'trailer.<token>.command' config option can already be used to
> > help with that, for example:
> >
> > -------
> > $ git config trailer.sign.key "Signed-off-by: "
> > $ git config trailer.sign.ifexists replace
> > $ git config trailer.sign.command "git log --author='\$ARG' -1
> > --format='format:%aN <%aE>'"
> > $ git interpret-trailers --trailer sign=Linus<<EOF
> > subject
> >
> > body
> > EOF
> > subject
> >
> > body
> >
> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> > -------
> >
> > So even without this patch, after your first patch that implements
> > `git commit --trailer ...`, it should be easy to setup something less
> > verbose and less error-prone.
>
> It is nice that it makes the complexity of 2/2 unnecessary ;-)

A little frustrated, both `--own-identity` and `@nickname` seem to be
 rejected. I will roll back to the first patch.