From: ZheNing Hu <adlternative@gmail.com>
Date: Sun, 27 Jun 2021 11:43:02 GMT
Subject: Re: [PATCH v5 02/15] [GSOC] ref-filter: add %(raw) atom
Message-ID: <CAOLTT8TK4cC1P-h+=wag8OdPc3C_Acd-dHY55NuA48UuuABAiA@mail.gmail.com>
In-Reply-To: <946c95bc-d57a-5b55-0dcf-5c4d6f980396@gmail.com>

Bagas Sanjaya <bagasdotme@gmail.com> 于2021年6月26日周六 上午8:42写道：
>
> On 25/06/21 23.02, ZheNing Hu via GitGitGadget wrote:
> > Note that `--format=%(raw)` cannot be used with `--python`, `--shell`,
> > `--tcl`, and `--perl` because if the binary raw data is passed to a
> > variable in such languages, these may not support arbitrary binary data
> > in their string variable type.
> >
>
> Commit message looks OK, but...
>
> > +Note that `--format=%(raw)` can not be used with `--python`, `--shell`, `--tcl`,
> > +`--perl` because the host language may not support arbitrary binary data in the
> > +variables of its string type.
> > +
>
> Seems like out of sync between commit message and the docs change above.
> Did you mean the (unsupported) host languages are Python, BASH script,
> TCL/TK, and Perl respectively? If so, the docs should say:
>

Indeed so. I will change them too.

> "Note that `--format=%(raw) can not be used with `--python`, `--shell`,
> `-tcl`, and `--perl` because such languages may not support arbitrary
> binary data in their string variable type."
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara

Thanks.
--
ZheNing Hu