From: ZheNing Hu <adlternative@gmail.com>
Date: Tue, 27 Apr 2021 12:24:32 GMT
Subject: Re: [PATCH v11 0/2] [GSOC] trailer: add new .cmd config option
Message-ID: <CAOLTT8QrX3sk1U6WM983pachj8q4fmW7jxEViXd4-Y-aSR1JeQ@mail.gmail.com>
In-Reply-To: <xmqq35vcfchn.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> 于2021年4月27日周二 下午2:49写道：
>
> ZheNing Hu <adlternative@gmail.com> writes:
>
> > Now I think that we should keep those trailers which ask for a
> > "name <email>" pair, like "Helped-by", "Signed-off-by", when we
> > provide a "help:","sign:" in command line, This allows the user to
> > dynamically fill in the "name <email>" pair of other people in the
> > commit message later. It is worthwhile for users to exit with exit(0).
> >
> > But those dispensable things like "Commit-Count", It must depend
> > on a person's statistics in the git repository. So "cnt:" is meaningless,
> > users' script can let it exit(1).
>
> Perhaps, but at this point what you think (or what I think) does not
> matter.  That was the whole point of letting .cmd script signal Git
> if the result from the invocation should be kept or discarded with
> its exit status.  What would be sufficient here for us to do is to
> agree that it would be good to have a minimal set (perhaps a pair)
> of examples to demonstrate that the script can choose to keep or
> discard a meaningless trailer entry with its exit status.

Yes, I argee.
Due to previous attempts, it seems that such an example is well given:
"Commit-Count" is the trailer that should be discarded.
"Signed-off-by" is the trailer worth be kept.

Thanks.
--
ZheNing Hu