From: Angus Hammond <angusgh@gmail.com>
Date: Thu, 17 May 2012 14:27:40 GMT
Subject: Re: [PATCH] send-email: support coloring dry-run output
Message-ID: <CAOBOgRaEnFOJ9=ZHczAq_TNerrrMciG8g0SHYDiKrqfhASU-iA@mail.gmail.com>
In-Reply-To: <1337260596-15498-1-git-send-email-pclouds@gmail.com>

This seems like it would be a useful patch for those of us using sendmail.
I'll admit I don't know any perl at all, but one bit seems a little
odd to me. Is there a reason you use 3 separate print statements to
deal with the colours on the Sendmail line, but a regex substitution
the second time? I have no idea which would be considered the better
practice but surely we should pick one and be consistent? Unless
there's some difference between the two that I'm missing.
Thanks
Angus