From: Arsh Srivastava <arshsrivastava00@gmail.com>
Date: Tue, 10 Mar 2026 17:56:13 GMT
Subject: Re: [PATCH v2] advice: add stashBeforeCheckout advice for dirty branch switches
Message-ID: <CAOAgETMjppTDG9jkV=zR+CVsEXwpVZ1peu3SbPZY9fNaKKmEMg@mail.gmail.com>
In-Reply-To: <xmqqeclrwrz4.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes

>Sign-off and Subject in body confuses

I thought writing sign-off was a necessity for my mail to be accepted

On Tue, 10 Mar 2026 at 22:18, Junio C Hamano <gitster@pobox.com> wrote:
>
> Arsh Srivastava <arshsrivastava00@gmail.com> writes:
>
> > Subject: Re: [GSOC] advice: add stashBeforeCheckout advice for dirty
> > branch switches
> >
> > Karthik Nayak <karthik.188@gmail.com> writes:
> >
> >> Doesn't 'ADVICE_COMMIT_BEFORE_MERGE' already do this?
> >> So won't this simply be duplicating the same message?
> >
> > Thank you for the detailed review. You are correct, the existing message
> > ...
> > I will rework the patch in that direction and send a v4.
> >
> > Signed-off-by: Arsh Srivastava <arshsrivastava00@gmail.com>
>
> Just a comment by a bystander, but it confuses me quite a lot to see
> in-body "Subject:" and "Sign-off" in a message that is *not* a patch
> at all.  What are you signing off with this signature?