From: Han Xin <chiyutianyi@gmail.com>
Date: Mon, 06 Dec 2021 03:20:23 GMT
Subject: Re: [PATCH v4 4/5] unpack-objects.c: add dry_run mode for get_data()
Message-ID: <CAO0brD2zHETRWz-0Bcy1+tjkFS0XF94+SdBj-sDfZcq5iG=6ZQ@mail.gmail.com>
In-Reply-To: <211203.86ee6tss9p.gmgdl@evledraar.gmail.com>

On Fri, Dec 3, 2021 at 10:00 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
>
> On Fri, Dec 03 2021, Han Xin wrote:
>
> > +     unsigned long bufsize = dry_run ? 4096 : size;
> > +     void *buf = xmallocz(bufsize);
>
> It's probably nothing, but in your CL you note that you changed another
> hardcoding from 4k to 8k, should this one still be 4k?
>
> It's probably fine, just wondering...

Yes, I think this is an omission from my work.