From: Mike Rappazzo Date: Fri, 10 Feb 2017 03:52:36 GMT Subject: Re: [PATCH] rev-parse --git-path: fix output when running in a subdirectory Message-ID: In-Reply-To: On Thu, Feb 9, 2017 at 5:54 PM, Junio C Hamano wrote: > > That leaves what the right single-step behaviour change should be. > As I recall Duy said something about --common-dir and other things > Mike's earlier change also covered, I'd prefer to leave it to three > of you to figure out what the final patch should be. > The tests which I covered in my previous patch [1] addressed the places where we identified similar problems. We should try to include some form of those tests. As far as implementation goes in rev-parse, the version in this thread is probably better that what I had, but it would need to also be applied to --git-common-dir and --shared-index-path. [1] http://public-inbox.org/git/1464261556-89722-2-git-send-email-rappazzo@gmail.com/