From: Mike Rappazzo Date: Fri, 11 Sep 2015 21:43:25 GMT Subject: Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c Message-ID: In-Reply-To: On Fri, Sep 11, 2015 at 12:16 PM, Junio C Hamano wrote: > Michael Rappazzo writes: > >> The code formerly in branch.c was largely the basis of the >> get_worktree_list implementation is now moved to worktree.c, >> and the find_shared_symref implementation has been refactored >> to use get_worktree_list >> > > Copying the bulk of the function in 1/3 and then removing the > original here made it somewhat hard to compare what got changed in > the implementation. > > I _think_ the code structure in the end result is more or less > right, though. Should I squash these first two commits together in the next series?