From: Roman Kagan Date: Mon, 23 Apr 2012 15:10:43 GMT Subject: Re: [PATCH 0/2] git-svn: fixes for intermittent SIGPIPE Message-ID: In-Reply-To: 23 апреля 2012 г. 18:44 пользователь Junio C Hamano написал: > Roman Kagan writes: > >> IIUC the series was approved by Eric.  What do I need to do now to >> have it reviewed for accepting into the master tree? > > I see this: > >        Date: Tue, 10 Apr 2012 21:11:20 +0000 >        From: Eric Wong >        Message-ID: <20120410211120.GA27555@dcvr.yhbt.net> > >        Roman Kagan wrote: >        > +             my $signew = POSIX::SigSet->new(SIGINT, SIGHUP, SIGTERM, >        > +                     SIGALRM, SIGPIPE, SIGUSR1, SIGUSR2); > >        Considering your 2/2 patch, can we remove SIGPIPE here? >        Otherwise, I think this series is good.  Thanks! > > What usually happens after such an intial round of review is for you to > think about the comments like this one given during the review, and > either submit a patch updated accordingly, or discuss why your original > is better than the suggested update, and then the reviewer responds to > it, and repeat the process until everybody involved in the discussion > accepts the outcome. I replied on the very same day that I thought that Eric's comment would better be addressed in a followup patch, and that patch would be purely cosmetic anyway. So I felt like I could wait until these two are merged or commented by more people. My bad; will resubmit the series with the third patch included to hopefully get Eric's full approval. Thanks, Roman.