From: Martin von Zweigbergk <martinvonz@gmail.com>
Date: Tue, 18 Sep 2012 05:37:02 GMT
Subject: Re: [PATCH 4/4] rebase -i: Add tests for "--edit-todo"
Message-ID: <CANiSa6jJTu8QmWTybN77-nMZezCVkcod-+wmEf-T7=nN-H1p=Q@mail.gmail.com>
In-Reply-To: <5058053C.6080206@gmail.com>

On Mon, Sep 17, 2012 at 10:23 PM, Andrew Wong <andrew.kw.w@gmail.com> wrote:
> On 09/18/12 00:58, Martin von Zweigbergk wrote:
>> On Mon, Sep 17, 2012 at 6:28 PM, Andrew Wong <andrew.kw.w@gmail.com> wrote:
>>> +       test M = $(git cat-file commit HEAD^ | sed -ne \$p) &&
>>> +       test L = $(git cat-file commit HEAD | sed -ne \$p)
>> I couldn't find "$" (match last line) in the POSIX man page for sed.
>> Besides, I think $(git show -s --format=%s HEAD) reads better.
> It's under "Addresses in sed":
>         ... a '$' character that addresses the last line of input ...

Ah, I just didn't look hard enough; sorry. Good to know.

FWIW, Acked-by: Martin von Zweigbergk <martinvonz@gmail.com>