From: Martin von Zweigbergk <martinvonz@gmail.com>
Date: Mon, 14 Jan 2013 00:05:16 GMT
Subject: Re: [PATCH v3 03/31] Add parse_pathspec() that converts cmdline args to struct pathspec
Message-ID: <CANiSa6icv7V7hoEzHQT0mgqjCDcSkuLvZ2M=6Q5gp6NcXJ20jQ@mail.gmail.com>
In-Reply-To: <1358080539-17436-4-git-send-email-pclouds@gmail.com>

On Sun, Jan 13, 2013 at 4:35 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> +static void parse_pathspec(struct pathspec *pathspec,
> +                          unsigned magic_mask, unsigned flags,
> +                          const char *prefix, const char **argv)
> +{
> +       struct pathspec_item *item;
> +       const char *entry = *argv;
> ...
> +       for (i = 0; i < n; i++) {
> +               const char *arg = argv[i];

Nit: "*argv" was assigned to "entry" above. Reassign that variable instead?