From: Martin von Zweigbergk Date: Tue, 15 Jan 2013 18:36:40 GMT Subject: Re: [PATCH v2 06/19] reset.c: remove unnecessary variable 'i' Message-ID: In-Reply-To: I suppose this was meant for everyone. Adding back the others. On Tue, Jan 15, 2013 at 10:27 AM, Holding, Lawrence (NZ) wrote: > Maybe use *argv instead of argv[0]? Sure. Everywhere? Also in the lines added in patch 17/19 that refer to both argv[0] and argv[1], such as "argv[1] && !get_sha1_treeish(argv[0], unused)"? Or is this just a sign that I'm making the code _more_ confusing to those who are more familiar with C?