From: Martin von Zweigbergk <martinvonz@gmail.com>
Date: Wed, 02 Jan 2013 17:07:11 GMT
Subject: Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed
Message-ID: <CANiSa6gqG_tBja_SyLSR5HCphaV7PYAk=ScXDdSk4VWpd-8uMw@mail.gmail.com>
In-Reply-To: <7va9sr4jgu.fsf@alter.siamese.dyndns.org>

> diff --git a/Makefile b/Makefile
> index 26b697d..2f5e2ab 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2167,8 +2167,14 @@ configure: configure.ac GIT-VERSION-FILE
>         $(RM) $<+
>
>  ifdef AUTOCONFIGURED
> -config.status: configure
> -       $(QUIET_GEN)if test -f config.status; then \
> +# We avoid depending on 'configure' here, because it gets rebuilt
> +# every time GIT-VERSION-FILE is modified, only to update the embedded
> +# version number string, which config.status does not care about.  We
> +# do want to recheck when the platform/environment detection logic
> +# changes, hence this depends on configure.ac.
> +config.status: configure.ac
> +       $(QUIET_GEN)$(MAKE) configure && \
> +       if test -f config.status; then \
>           ./config.status --recheck; \
>         else \
>           ./configure; \

Looks great (at least from my 'make'-incompetent point of view :-)). I
do appreciate the comment. Thanks, everyone.