From: Jiang Xin <worldhello.net@gmail.com>
Date: Wed, 04 Oct 2023 13:02:25 GMT
Subject: Re: [PATCH v2 3/3] pkt-line: do not chomp newlines for sideband messages
Message-ID: <CANYiYbHp-3YuSPHnR8gjS40UJLrJV5FPzqd_BtjyR8TAALhfRQ@mail.gmail.com>
In-Reply-To: <ZRKax7Me5uIHKHoC@ugly>

On Tue, Sep 26, 2023 at 4:48 PM Oswald Buddenhagen
<oswald.buddenhagen@gmx.de> wrote:
>
> >Jiang Xin <worldhello.net@gmail.com> writes:
> >
> >> +++ b/pkt-line.c
> >> @@ -462,8 +462,33 @@ enum packet_read_status packet_read_with_status(int fd, char **src_buffer,
> >>      }
> >> +                    case 2:
> >> +                            /* fallthrough */
> >> +                    case 3:
> >
> while not entirely unprecedented, it's unnecessary and even
> counter-productive to annotate directly adjacent cases with fallthrough.

I see in "blame.c" there are directly adjacent cases like below. I
will remove the fallthrough statement.

        case 'A':
        case 'T':
                /* Did not exist in parent, or type changed */
                break;

Thanks.