From: Jiang Xin <worldhello.net@gmail.com>
Date: Mon, 13 May 2013 02:47:41 GMT
Subject: Re: [PATCH v7 03/10] Add colors to interactive git-clean
Message-ID: <CANYiYbGqZ6FiHTZgejrA3a-njffQNJyaefFmCWfycuE6PGjwbA@mail.gmail.com>
In-Reply-To: <vpqfvxsi0gw.fsf@grenoble-inp.fr>

2013/5/13 Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>:
> Jiang Xin <worldhello.net@gmail.com> writes:
>
>>  * color.interactive.<slot>: Use customized color for interactive
>>    git-clean output (like git add --interactive). <slot> may be
>>    prompt, header, help or error.
>
> This should go to the documentation (a short summary is welcome in the
> commit messages in addition, but users won't read this...)
>
>> +     if (!prefixcmp(var, "color.interactive.")) {
>> +             int slot = parse_clean_color_slot(var, 18);
>
> For readability and maintainability: please use
> strlen("color.interactive."), not 18.

Feel like conventional:

    git grep -C2 prefixcmp builtin/apply.c builtin/archive.c
builtin/branch.c builtin/checkout.c

But maybe 18 characters are too long. ;-)


-- 
Jiang Xin
http://www.worldhello.net/