From: Jiang Xin <worldhello.net@gmail.com>
Date: Mon, 23 May 2022 08:30:38 GMT
Subject: Re: [PATCH v3 6/9] po/git.pot: don't check in result of "make pot"
Message-ID: <CANYiYbG6qLvBDHUkQ+6JRL22obLA14nrdcgpqB77TN4Bxqmybg@mail.gmail.com>
In-Reply-To: <220523.86r14kzp2t.gmgdl@evledraar.gmail.com>

On Mon, May 23, 2022 at 3:27 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
>
> On Mon, May 23 2022, Jiang Xin wrote:
>
> >  .PHONY: pot
> >  pot: po/git.pot
> > @@ -3319,6 +3319,7 @@ dist-doc: git$X
> >
> >  distclean: clean
> >       $(RM) configure
> > +     $(RM) po/git.pot
>
> I think I noted "why not add this to clean?" in an earlier round, but
> didn't think it through.
>
> On second thought we should do that, but the reason is that "distclean"
> should only clean things that you get if you do "make dist".
>
> I.e. we add "configure" to a generated tarball, but not po/git.pot, so
> this should just be under regular "clean", not "distclean".

Will remove "po/git.pot" under regular "clean" rule in next reroll. I
copied it from your original patch without thinking carefully.