From: Jiang Xin <worldhello.net@gmail.com>
Date: Mon, 03 Jun 2013 11:20:18 GMT
Subject: Re: [RFC v2] reflog: show committer date in verbose mode
Message-ID: <CANYiYbG-f+bM0jP0f-R-ciuR0sR13+8FcYkTas-X0LOh1mPRfg@mail.gmail.com>
In-Reply-To: <CALkWK0k-cikpwue4iQDGJgP4NrGdkCw2r=dzzP78+QbsA5BiMA@mail.gmail.com>

2013/6/3 Ramkumar Ramachandra <artagnon@gmail.com>:
> Jiang Xin wrote:
>> It will be nice to add this pretty formatter automatically when run
>> `git reflog` in verbose mode. And in order to support verbose mode, add
>> new flag "verbose" in struct rev_info.
>
> Sorry I missed earlier revisions of this patch.  Generally speaking,
> "verbose" is a bad way to control format-specifiers.  Why not add to
> the list of pretty-format specifiers (like oneline, short, medium,
> full)?  Also, this patch is extremely pervasive in that it teaches a
> poorly defined "verbosity" to a very low layer: revision.c/revision.h.

I also feel bad when adding new flag "verbose" into rev_info. = =b

CommitDate is more significant than AuthorDate for reflog. In order to
show CommitDate, at least we provide "fuller" formatter, such as
"git reflog --pretty=fuller". It's output is not as compact as:

    $ git reflog show \
       --pretty="%Cred%h%Creset %gd: %gs%n    %Cblue%ci (%cr)%Creset%n    %s"

Introduce new pretty-format like this is not suitable I think. Maybe
I have to define my own alias and use it myself. ;-)


-- 
Jiang Xin