From: Jiang Xin Date: Mon, 23 Jul 2012 03:14:17 GMT Subject: Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge Message-ID: In-Reply-To: <7vmx2rr320.fsf@alter.siamese.dyndns.org> 2012/7/23 Junio C Hamano : > I do not understand why many of these have Stefano's S-o-b in them. > If you are relaying what Stefano originally wrote, then the author > (i.e. "From: ") and the first S-o-b would say Stefano, and your > S-o-b will follow it, but that is probably not the case. > I'll drop the S-o-b lines for now. It is because Stefano offers lots of help for correcting syntax errors and misspellings in the original commit logs. Should I use Reviewed-by tag instead of S-o-b? And in PATCH 3/7, there is a Ævar's S-o-b, it is because the workaround comes from Ævar's idea. Is this tag suitable? I think I should add a Reported-by tag for Vincent, as he report it first in this mail: http://thread.gmane.org/gmane.comp.version-control.git/199042 > By the way, is there any existing test that needs to gain GETTEXT_POISON > or test_i18ncmp with this change? I find one test case failed, and correct it in PATCH 3/7. -- Jiang Xin