From: Jiang Xin <worldhello.net@gmail.com>
Date: Tue, 29 May 2012 04:46:08 GMT
Subject: Re: Vietnamese l10n pull request problems
Message-ID: <CANYiYbFBqv_rGZJfiiTd6iNiDtK1cG32nWJS93_kPeKqNi5-dw@mail.gmail.com>
In-Reply-To: <4fc33949.24ef440a.22da.fffff905@mx.google.com>

2012/5/28 Trần Ngọc Quân <vnwildman@gmail.com>:
> done! And also translated some tring.

Your commit log still not quite sane. I update the po-helper.sh script,
which can help you checking your commit log.

1. Checkout po/po-helper.sh script, using:

    $ git remote add git-l10n git://github.com/git-l10n/git-po.git
    $ git fetch git-l10n
    $ git checkout git-l10n/po-helper -- po/po-helper.sh

2. Check your commit with this helper script:

    $ po/po-helper.sh check commits 6f6731e HEAD

3. You will get the following error mesage:

    $ po/po-helper.sh check commits 6f6731e HEAD
    Error: in commit 024e5d89d764edccf76fcf480ac4b2c5d2a2f95d, subject
should not end with a punctuation.
           "Fix conflick in vnwildman/git repository."
    Error: in commit 024e5d89d764edccf76fcf480ac4b2c5d2a2f95d,
multiple lines found in subject.
    Error: in commit 17c1d44fffbb0c4454215015a85791f548900a85, subject
should not end with a punctuation.
           "Continue translate Vietnamese translation."
    Error: in commit dd58f041707cdbdefccca4282c3afaa6c7138cf2, subject
should not end with a punctuation.
           "Init translation for Vietnamese."

4. Currently, this helper script check:

    * Subject line no more than 50 characters.
    * Subject line should not end with a dot (punctuation), this waste
is unnecessary.
    * Insert a blank line between the one line subject and other descriptions.
    * Long descriptions must line wrap at 72 characters.
    * Must add a Signed-off-by line if the commit is not a merge commit.

This script does not perform grammer check, you should check by yourself.
Squash the three commit into one maybe a solution. Your commits  are:

$ git log -3
commit 024e5d89d764edccf76fcf480ac4b2c5d2a2f95d
Author: Tran Ngoc Quan <vnwildman@gmail.com>
Date:   Mon May 28 15:29:02 2012 +0700

    Fix conflick in vnwildman/git repository.
    Transtate more 6% into Vietnamese.
    Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>

commit 17c1d44fffbb0c4454215015a85791f548900a85
Author: Tran Ngoc Quan <vnwildman@gmail.com>
Date:   Fri May 25 14:32:44 2012 +0700

    Continue translate Vietnamese translation.

    Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>

commit dd58f041707cdbdefccca4282c3afaa6c7138cf2
Author: Tran Ngoc Quan <vnwildman@gmail.com>
Date:   Sun May 6 09:42:49 2012 +0700

    Init translation for Vietnamese.

    Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>
    Signed-off-by: Jiang Xin <worldhello.net@gmail.com>


-- 
Jiang Xin