From: Jiang Xin <worldhello.net@gmail.com>
Date: Mon, 03 Nov 2014 01:46:25 GMT
Subject: Re: [L10N] Startup of Git 2.2.0 l10n round 1
Message-ID: <CANYiYbERpzF2Fo2nnEmMmELh3ES10q87Tt13F4r5VZsb9UuJhw@mail.gmail.com>
In-Reply-To: <20141102.200647.1807459583469654728.chriscool@tuxfamily.org>

2014-11-03 3:06 GMT+08:00 Christian Couder <chriscool@tuxfamily.org>:
> From: Alexander Shopov <ash@kambanaria.org>
>
>> Can you please disambiguate message:
>> msgid "more than one %s"
>>
>> It means that something somewhere was repeated but does not point what
>> and where. Perhaps users care about that.
>
> If you configure something like:
>
> [trailer "stuff"]
>         key = Stuff
>         key = Other
>
> You will get:
>
> $ echo | LANG=C git interpret-trailers
> warning: more than one trailer.stuff.key
>
> Which means that more than value was configured for the
> "trailer.stuff.key" configuration option. And it makes no sense
> because only one should be the canonical one.
>
>> It is now used 3 times (trailer.c:552 trailer.c:557
>> builtin/remote.c:288) but points to different things that were
>> repeated. It used to mean only that there is a "remote' section
>> repeated.
>
> In builtin/remote.c the warning is also when more than one value is
> given for a configuration option.
>
> Feel free to suggest some more explicit warning in both cases if you
> want. (Maybe adding " is configured" at the end would be enough.) A
> patch would be even better.
>

Yes, Alexander could send a patch for this. It's an I18N thing, not L10n,
so send a patch to the list if you like. @alshopov

> Thanks,
> Christian.

-- 
Jiang Xin