From: Jakub Narębski <jnareb@gmail.com>
Date: Wed, 04 Dec 2013 15:11:42 GMT
Subject: Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/
Message-ID: <CANQwDwdiNHFCChVdkKxkEa+HOKzzhgfzy4d6iZB6ejSfva3Z3A@mail.gmail.com>
In-Reply-To: <1386164583-14109-2-git-send-email-krzesimir@endocode.com>

On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak <krzesimir@endocode.com> wrote:

> So future reader will know what does it mean without running "perldoc
> perlvar".

Hmmm... shouldn't future reader know it anyway?  It is not that cryptic.
I'd say it is idiomatic Perl.

Besides, it is not the only place where we set input record separator to NUL,
to match corresponding option to git command to separate records with NUL
(the '-z' option in this case).  Others are git_get_path_by_hash(),
parse_commit(),
and parse_commits(), git_tree(), not including places where we set $/ to undef
to slurp whole file: git_get_link_target(), git_blobdiff() for $format
== 'plain', etc.

> Signed-off-by: Krzesimir Nowak <krzesimir@endocode.com>
> ---
>  gitweb/gitweb.perl | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 68c77f6..ee61f9e 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -2629,6 +2629,8 @@ sub git_parse_project_config {
>         my $section_regexp = shift;
>         my %config;
>
> +       # input record separator, so getline does end on null, not
> +       # newline
>         local $/ = "\0";

It is here because of '-z' option below (to account for values with
embedded newlines).

>
>         open my $fh, "-|", git_cmd(), "config", '-z', '-l',
> --
> 1.8.3.1
>



-- 
Jakub Narebski