From: Ivan Frade <ifrade@google.com>
Date: Fri, 29 Oct 2021 18:42:36 GMT
Subject: Re: [PATCH v5 1/2] fetch-pack: redact packfile urls in traces
Message-ID: <CANQMx9VXRnLjMgvYM63tq8aecvWNd-0cxi+XMSkkwm-iUeX+1g@mail.gmail.com>
In-Reply-To: <xmqqa6isohve.fsf@gitster.g>

On Thu, Oct 28, 2021 at 4:21 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Ivan Frade via GitGitGadget" <gitgitgadget@gmail.com> writes:
>

> > +     len = strspn(buffer, "0123456789abcdefABCDEF");
> > +     if (!(len == 40 || len == 64) || buffer[len] != ' ')
> > +             return NULL; /* required "<hash>SP" not seen */
>
> People may have comments on hardcoded 40/64 here and offer a better
> way to write it ;-)

Latest version uses the_hash_algo->hexsz:

+       if (len != (int)the_hash_algo->hexsz || buffer[len] != ' ')
+               return NULL; /* required "<hash>SP" not seen */

Thanks!