From: Alexander Kuleshov <kuleshovmail@gmail.com>
Date: Fri, 19 Jun 2015 11:34:09 GMT
Subject: Re: [PATCH] format-patch: introduce format.outputDirectory configuration
Message-ID: <CANCZXo7j=5zcjhxXAeEKagRmUVTNVyaDTzyt1LL_-uufGARCKA@mail.gmail.com>
In-Reply-To: <1537731273.629800.1434713654223.JavaMail.zimbra@ensimag.grenoble-inp.fr>

Hello,

Yes, thank you for advice.

2015-06-19 17:34 GMT+06:00 Remi Galan Alfonso
<remi.galan-alfonso@ensimag.grenoble-inp.fr>:
> Alexander Kuleshov <kuleshovmail@gmail.com> writes:
>> +test_expect_success "format-patch format.outputDirectory option" '
>> + git config format.outputDirectory "patches/" &&
>> + git format-patch master..side &&
>> + cnt=$(ls | wc -l) &&
>> + echo $cnt &&
>> + test $cnt = 3 &&
>> + git config --unset format.outputDirectory
>> +'
>
> You should probably do:
>> + test_config format.outputDirectory "patches/" &&
>
> instead of:
>> + git config format.outputDirectory "patches/" &&
>> [...]
>> + git config --unset format.outputDirectory
>
> This way there shouldn't be any problem with the
> tests following yours if your test fails in the middle.
>
> Rémi