From: Nipunn Koorapati <nipunn1313@gmail.com>
Date: Wed, 21 Oct 2020 23:22:54 GMT
Subject: Re: [PATCH 1/2] fsmonitor: stop inline'ing mark_fsmonitor_valid / _invalid
Message-ID: <CAN8Z4-WY8Q-VCujRJFmEpDwX8OYfRYFAgam0CFbQVwDTRU+DKw@mail.gmail.com>
In-Reply-To: <20201021205537.GB1270359@nand.local>

> Letting the compiler inline these is fine, but...
>
> Any reason that these need to be externed explicitly? Note that these
> functions are already externed by default since you haven't said
> otherwise (and for no other reason than this'd be the only explicitly
> externed function in fsmonitor.h).

Did not have a reason or strong opinion here. It was this way, because this was
the way alexmv used it originally - but it does compile in either manner. The
thread Junio linked does seem to indicate preference for extern to avoid
confusion.

--Nipunn