From: Brian Gesiak <modocache@gmail.com>
Date: Tue, 27 May 2014 11:32:54 GMT
Subject: Re: [PATCH 01/15] builtin/add.c: rearrange xcalloc arguments
Message-ID: <CAN7MxmXVDTiQv5J9cU2E8iS=BNROw3q9NVaBuG7aQP-7=Qo_ZQ@mail.gmail.com>
In-Reply-To: <CAPig+cRE0LUaNLTJARBCmoDn7cR1bbgi8At0ChgSDWBjDPaNjg@mail.gmail.com>

Oomph, how embarrassing. Thanks for pointing that out!

Would it be better if I rerolled the patches?

- Brian Gesiak

On Tue, May 27, 2014 at 12:25 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Mon, May 26, 2014 at 11:33 AM, Brian Gesiak <modocache@gmail.com> wrote:
>> xcalloc takes two arguments: the number of elements and their size.
>> run_add_interactive passes the arguments in reverse order, passing the
>> size of a char*, followed by the number of char* to be allocated.
>> Rearrgange them so they are in the correct order.
>
> s/Rearrgange/Rearrange/
>
> Same misspelling afflicts the entire patch series.
>
>> Signed-off-by: Brian Gesiak <modocache@gmail.com>
>> ---
>>  builtin/add.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/builtin/add.c b/builtin/add.c
>> index 672adc0..488acf4 100644
>> --- a/builtin/add.c
>> +++ b/builtin/add.c
>> @@ -248,7 +248,7 @@ int run_add_interactive(const char *revision, const char *patch_mode,
>>         int status, ac, i;
>>         const char **args;
>>
>> -       args = xcalloc(sizeof(const char *), (pathspec->nr + 6));
>> +       args = xcalloc((pathspec->nr + 6), sizeof(const char *));
>>         ac = 0;
>>         args[ac++] = "add--interactive";
>>         if (patch_mode)
>> --
>> 2.0.0.rc1.543.gc8042da