From: Martin Ågren <martin.agren@gmail.com>
Date: Thu, 16 Nov 2017 10:55:55 GMT
Subject: Re: [PATCH] sequencer: reschedule pick if index can't be locked
Message-ID: <CAN0heSrcAQhyzzB5c=W-diQecHgVQUC69xQwqnc36hSPVBpNig@mail.gmail.com>
In-Reply-To: <804e30dd-3c06-02c1-e5c0-f07265635943@talktalk.net>

On 16 November 2017 at 11:43, Phillip Wood <phillip.wood@talktalk.net> wrote:
> On 15/11/17 18:44, Martin Ågren wrote:
>>
>> On 15 November 2017 at 11:41, Phillip Wood <phillip.wood@talktalk.net>
>> wrote:
>>
>>  From the commit message, I would have expected the flags to be zero. This
>> patch
>> does not only turn off the die-ing, it also tells the lockfile-API to
>> print an
>> error message before returning. I don't have an opinion on whether that
>> extra
>> verboseness is good or bad, but if it's wanted, I think the commit message
>> should mention this change.
>
>
> Hi Martin, thanks for your comments. LOCK_DIE_ON_ERROR also prints the same
> warning so that behavior is unchanged by this patch, though mentioning it in
> the commit message would be no bad thing.

Argh, you're right of course. Sorry for this.

Martin