From: Martin Ågren <martin.agren@gmail.com>
Date: Tue, 11 Jul 2017 13:47:50 GMT
Subject: Re: [PATCH 3/7] git.c: provide setup_auto_pager()
Message-ID: <CAN0heSr0czHkoxaYKeR-L-G01PWrHnLF-cArkH3ufpoR1+HZzw@mail.gmail.com>
In-Reply-To: <20170711103715.a4jfbjop227bfuhh@sigill.intra.peff.net>

On 11 July 2017 at 12:37, Jeff King <peff@peff.net> wrote:
> On Mon, Jul 10, 2017 at 11:55:16PM +0200, Martin Ågren wrote:
>
>> +void setup_auto_pager(const char *cmd, int def)
>> +{
>> +     if (use_pager != -1)
>> +             return;
>
> I think you probably also want to return early here if pager_in_use()
> is true. If a script runs "git tag -l", you wouldn't want to start a new
> pager when the outer script has already been paged (either via config,
> or via "git -p").

Good point. Thanks.

Martin