From: Martin Ågren Date: Thu, 17 Aug 2017 18:21:26 GMT Subject: Re: [PATCH v4 2/3] builtin/branch: stop supporting the use of --set-upstream option Message-ID: In-Reply-To: <20170817025425.6647-2-kaarticsivaraam91196@gmail.com> On 17 August 2017 at 04:54, Kaartic Sivaraam wrote: > Helped-by: Martin Ågren , Junio C Hamano > Signed-off-by: Kaartic Sivaraam I didn't expect a "Helped-by", all I did was to give some random comments. :-) I'm not so sure about the comma-separation, that seems to be a first in the project. > * The option has not yet been removed from the synopsis of the documentation and I think > we can't remove it from the 'Synopsis' porion of the documentation as it doesn't make > sense (at least to me) to give a description of an option not listed in the synopsis. The "git interpret-trailers --parse" thread nearby is adding some options without mentioning them in the synopsis [1], and those options can actually be useful, whereas "--set-upstream" only results in a fatal error. So I don't know. > Moreover, we have to state the reason for not supporting it in some place. > > I guess the phrase 'no longer supported' is equally communicative. Let me know if that was not > a right decision. I think it's ok. Of course, I know exactly what you want to say, and why, so I'm biased. :-) [1] https://public-inbox.org/git/20170815102334.qc4w7akl44bti44x@sigill.intra.peff.net/