From: Martin Ågren <martin.agren@gmail.com>
Date: Sat, 12 Aug 2017 13:27:21 GMT
Subject: Re: [PATCH 5/9] Convert various things to size_t
Message-ID: <CAN0heSqu0evvo7dFPwWvgEthoafCVZmJKbRftBbHRhtN_du4HQ@mail.gmail.com>
In-Reply-To: <1502527643-21944-5-git-send-email-martin@mail.zuhause>

On 12 August 2017 at 10:47, Martin Koegler <martin.koegler@chello.at> wrote:
> From: Martin Koegler <martin.koegler@chello.at>
>
> ---
>  bisect.c                | 2 +-
>  blame.c                 | 2 +-
>  builtin/fmt-merge-msg.c | 2 +-
>  builtin/mktag.c         | 2 +-
>  dir.c                   | 4 ++--
>  dir.h                   | 2 +-
>  6 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/bisect.c b/bisect.c
> index 2549eaf..0580c82 100644
> --- a/bisect.c
> +++ b/bisect.c
> @@ -131,7 +131,7 @@ static void show_list(const char *debug, int counted, int nr,
>                 struct commit *commit = p->item;
>                 unsigned flags = commit->object.flags;
>                 enum object_type type;
> -               unsigned long size;
> +               size_t size;
>                 char *buf = read_sha1_file(commit->object.sha1, &type, &size);
>                 const char *subject_start;
>                 int subject_len;

Would this need to be done in a patch where read_sha1_file is converted?