From: Martin Ågren <martin.agren@gmail.com>
Date: Sat, 16 May 2020 11:13:39 GMT
Subject: Re: [PATCH 30/44] connect: pass full packet reader when parsing v2 refs
Message-ID: <CAN0heSqoGVAbfnDAG+PKnuCa81F=euGCBnf6Vk=a7wjvNc+i-A@mail.gmail.com>
In-Reply-To: <20200513005424.81369-31-sandals@crustytoothpaste.net>

On Wed, 13 May 2020 at 02:56, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> @@ -466,9 +467,10 @@ struct ref **get_remote_refs(int fd_out, struct packet_reader *reader,
>         }
>         packet_flush(fd_out);
>
> +

Ah, this is where that line from patch 2 went. ;-)


>         /* Process response from server */
>         while (packet_reader_read(reader) == PACKET_READ_NORMAL) {
> -               if (!process_ref_v2(reader->line, &list))
> +               if (!process_ref_v2(reader, &list))
>                         die(_("invalid ls-refs response: %s"), reader->line);
>         }

Martin