From: Martin Ă…gren Date: Sat, 12 May 2018 20:55:48 GMT Subject: Re: [PATCH v2 07/12] commit-graph: load a root tree from specific graph Message-ID: In-Reply-To: <20180511211504.79877-8-dstolee@microsoft.com> On 11 May 2018 at 23:15, Derrick Stolee wrote: > -struct tree *get_commit_tree_in_graph(const struct commit *c) > +static struct tree *get_commit_tree_in_graph_one(struct commit_graph *g, > + const struct commit *c) > { > if (c->maybe_tree) > return c->maybe_tree; > if (c->graph_pos == COMMIT_NOT_FROM_GRAPH) > BUG("get_commit_tree_in_graph called from non-commit-graph commit"); Update the function name in the BUG? Not that it will ever matter. ;-) (This one is now static, ok.)