From: Martin Ă…gren Date: Thu, 30 Jan 2020 22:19:55 GMT Subject: Re: [PATCH v5 03/15] bugreport: gather git version and build info Message-ID: In-Reply-To: <20200124033436.81097-4-emilyshaffer@google.com> On Fri, 24 Jan 2020 at 04:40, wrote: > +static void get_system_info(struct strbuf *sys_info) > +{ > + struct strbuf version_info = STRBUF_INIT; > + > + /* get git version from native cmd */ > + strbuf_addstr(sys_info, "git version:\n"); > + get_version_info(&version_info, 1); > + strbuf_addbuf(sys_info, &version_info); > + strbuf_complete_line(sys_info); This leaks version_info. > +} Martin