From: Martin Ågren <martin.agren@gmail.com>
Date: Thu, 30 Jan 2020 22:28:40 GMT
Subject: Re: [PATCH v5 08/15] bugreport: include user interactive shell
Message-ID: <CAN0heSq9AdF_WPmSkxDA3cPzOQBAbuw4oa+8azvLtjbP-jQfKw@mail.gmail.com>
In-Reply-To: <20200124033436.81097-9-emilyshaffer@google.com>

On Fri, 24 Jan 2020 at 04:41, <emilyshaffer@google.com> wrote:
> +       char *shell = NULL;

(Unnecessary initialization.)

> +       shell = getenv("SHELL");
> +       strbuf_addf(sys_info, "$SHELL (typically, interactive shell): %s\n",
> +                   shell ? shell : "(NULL)");

Thanks for avoiding a classic pitfall. :-)

"<unused>" instead of "(NULL)"? "NULL" is mostly an implementation
detail.


Martin