From: Martin Ågren <martin.agren@gmail.com>
Date: Thu, 23 Jan 2020 20:28:18 GMT
Subject: Re: [PATCH 1/2] doc: sparse-checkout: mention --cone option
Message-ID: <CAN0heSq3gvZeUXnqzbjFY-1axmFXEJDO4oRp9abRO8TuxJQuDw@mail.gmail.com>
In-Reply-To: <6ec39af930871496dd7694ea27eeca69d5d60c96.1579805218.git.matheus.bernardino@usp.br>

Hi Matheus,

On Thu, 23 Jan 2020 at 20:02, Matheus Tavares <matheus.bernardino@usp.br> wrote:
> In af09ce2 ("sparse-checkout: init and set in cone mode", 2019-11-21),
> the '--cone' option was added to 'git sparse-checkout init'. Add this
> option to the respective doc file.

Nit: s/respective/corresponding/

"Respective" sounds -- to me at least -- like you're tweaking two
different files. Maybe that's just me.

>  To avoid interfering with other worktrees, it first enables the
>  `extensions.worktreeConfig` setting and makes sure to set the
>  `core.sparseCheckout` setting in the worktree-specific config file.
> ++
> +When `--cone` is provided the `core.sparseCheckoutCone` setting is also

Nit: maybe add a comma after "provided". Without it, I could see someone
false-starting the parsing as "provided with the" or even "provided to
the". Those readings obviously don't work out in the end, but with an
extra comma, I think it's easier to just naturally read this the way
it's intended.

> +set, allowing for better performance with a limited set of patterns
> +(see 'CONE PATTERN SET' bellow).

s/bellow/below/

Martin