From: Martin Ågren <martin.agren@gmail.com>
Date: Fri, 02 Aug 2019 09:43:00 GMT
Subject: Re: [PATCH v3 1/4] t7503: verify proper hook execution
Message-ID: <CAN0heSpyS6T-T8ueZc6L_zrgLrutf6P_pNYe=KJ+SpF+ycgfmA@mail.gmail.com>
In-Reply-To: <f0476b2b1e1e1f1d528b94523e86f210ccbd7dab.1564695893.git.steadmon@google.com>

On Fri, 2 Aug 2019 at 00:20, Josh Steadmon <steadmon@google.com> wrote:
>
> t7503 did not verify that the expected hooks actually ran during
> testing. Fix that by making the hook scripts write their $0 into a file
> so that we can compare actual execution vs. expected execution.

It could be argued that this test is perfectly fine as long as there is
just one hook to choose from, and as long as we're fine with failing
tests being a bit non-obvious to debug.  Since we'll soon have two hooks
to choose from in this test, we really want to make sure that we're
executing the right one, not just "at least one". (No need to reroll,
this is just me thinking out loud.)


Martin