From: Martin Ågren <martin.agren@gmail.com>
Date: Sun, 28 Feb 2021 20:01:03 GMT
Subject: Re: [PATCH v2] convert: fail gracefully upon missing clean cmd on required filter
Message-ID: <CAN0heSpZ4938f+Wd_LOnykCpLbWernXzLJU02LA79axcGCA_-Q@mail.gmail.com>
In-Reply-To: <ead5b3145c0cbf726c2fe06f5c95536373c85265.1614354223.git.matheus.bernardino@usp.br>

On Fri, 26 Feb 2021 at 17:24, Matheus Tavares <matheus.bernardino@usp.br> wrote:
> This assertion is not really necessary, as the apply_filter() call below
> it already performs the same check. And when this condition is not met,

> -       assert(ca.drv->clean || ca.drv->process);

FWIW, this LGTM.

> +       test_i18ngrep "fatal: test.ac: clean filter .absentclean. failed" stderr

> +       test_i18ngrep "fatal: test.as: smudge filter absentsmudge failed" stderr

(Funny how these two error messages differ in quoting. That's obviously
not anything your patch needs to fix.)

Martin