From: Martin Ågren <martin.agren@gmail.com>
Date: Wed, 05 Feb 2020 20:14:07 GMT
Subject: Re: [PATCH v5 08/15] bugreport: include user interactive shell
Message-ID: <CAN0heSpXcuBRjQvAwPpS6bM7gBs1LQQZggJBEgLOGCXM6GSrqQ@mail.gmail.com>
In-Reply-To: <xmqqmu9w6bop.fsf@gitster-ct.c.googlers.com>

On Wed, 5 Feb 2020 at 21:06, Junio C Hamano <gitster@pobox.com> wrote:
>
> Martin Ågren <martin.agren@gmail.com> writes:
>
> > On Fri, 24 Jan 2020 at 04:41, <emilyshaffer@google.com> wrote:
> >> +       char *shell = NULL;
> >
> > (Unnecessary initialization.)
> >
> >> +       shell = getenv("SHELL");
> >> +       strbuf_addf(sys_info, "$SHELL (typically, interactive shell): %s\n",
> >> +                   shell ? shell : "(NULL)");
> >
> > Thanks for avoiding a classic pitfall. :-)
> >
> > "<unused>" instead of "(NULL)"? "NULL" is mostly an implementation
> > detail.
>
> Isn't that <unset>?

Heh, yes, "SHELL: unused" sounds wrong. :-)

Martin