From: Martin Ågren <martin.agren@gmail.com>
Date: Fri, 30 Aug 2019 04:03:08 GMT
Subject: Re: [PATCH] clarify documentation for remote helpers
Message-ID: <CAN0heSosCnn5msMX18YPwrKJzWkSWptWSFRunQdLE7T7Lc4-OA@mail.gmail.com>
In-Reply-To: <20190829210301.18467-1-dturner@twosigma.com>

On Thu, 29 Aug 2019 at 23:06, David Turner <dturner@twosigma.com> wrote:

> -Optionally may output a 'lock <file>' line indicating a file under
> -GIT_DIR/objects/pack which is keeping a pack until refs can be
> -suitably updated.
> +Optionally may output a 'lock <file>' line indicating the full path of
> +a file under under GIT_DIR/objects/pack which is keeping a pack until
> +refs can be suitably updated.  The path must end with ".keep".

"under under".

Also -- and I realize this is nothing new in your patch -- "GIT_DIR"
should be prefixed with a '$' and that whole path wrapped in backticks
so it gets monospaced. In total, my suggestion would be

-+a file under under GIT_DIR/objects/pack which is keeping a pack until
++a file under `$GIT_DIR/objects/pack` which is keeping a pack until

Whether what you're saying is actually *true*, sorry, no idea. I just
have those nits above to offer.

Martin